You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was impossible to compile dragonfly on my mac when CXX flag was set. The issue is that building the reflex lib explicitly set the CXX to CMAKE_CXX_COMPILER. However when the first is set in bash and the second is empty, cmake will try to resolve the value of CMAKE_CXX_COMPILER which would be different than the one set via the variable CXX.
kostasrim
changed the title
fix: remove explicit CXX from reflex third party
[do not review] fix: remove explicit CXX from reflex third party
Feb 12, 2025
Removing CMAKE_CXX_COMPILER from reflex causes a linker failure with an error std::__1::basic_string. This is a name mangle for libc++ and not libstdc++ which we would expect with gcc-12.
The interesting thing is that the value of CMAKE_CXX_COMPILER when not explicitly set is deduced differently on our github runner(macos-13) and on my machine (macos-14).
The former, respects the value of CXX env variable(when set) such that CMAKE_CXX_COMPILER takes the value of CXX. However, this is not true for my machine. My CXX is set to /usr/bin/clang++ and its value is ignored by CMAKE_CXX_COMPILER and instead is deduced to /Library/Developer/CommandLineTools/usr/bin/clang++.
This is problematic because /Library/Dev/...does not set the include and library paths of the c++ standard library as opposed to /usr/bin/clang++ which does that for us.
Therefore I am forced to use CMAKE_CXX_COMPILER explicitly when invoking cmake even if CXX env is set if I want to compile with the llvm supplied by macos. This is rather unfortunate and error prone (as you need to remember to set CMAKE_CXX or you won't compile) but I don't see a good way to resolve.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kostasrim
changed the title
It was impossible to compile dragonfly on my mac when
CXXflag was set. The issue is that building the reflex lib explicitly set theCXXtoCMAKE_CXX_COMPILER. However when the first is set in bash and the second is empty, cmake will try to resolve the value ofCMAKE_CXX_COMPILERwhich would be different than the one set via the variableCXX.